Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added image scanning docs #3683

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tomhobson
Copy link
Member

Description

This is a draft for the basic of image scanning.

I found this pending, but haven't had time to pick it up to complete it yet.

It would also be nice to include some of the tekton chains bits as well as the extra learnings that we have from trivy now.

Fixes # (issue)

Checklist:

  • I have mentioned the appropriate type(scope), as referenced here in the commit message and PR title for the semantic checks to pass.
  • I have signed off the commit, as per instructions mentioned here.
  • [ x] Any dependent changes have already been merged.

@tomhobson
Copy link
Member Author

tomhobson commented Dec 19, 2022

/hold

not ready yet, should have opened as a draft

@sonarcloud
Copy link

sonarcloud bot commented Dec 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jenkins-x-bot
Copy link
Contributor

@tomhobson: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pr 705bb72 link /test pr
preview 705bb72 link /test preview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign tomhobson
You can assign the PR to them by writing /assign @tomhobson in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants