chore: this warning isn't actionable so let's remove it

[hutchic]

Based on what I've been able to discern from slack / github jenkins-x/jx#8589 isn't an actionable warning. On top of that it seems backwards compatibility is going to be maintained.

With that in mind let's not create a non-actionable warning

[jenkins-x-bot]

Hi @hutchic. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

[jrx-sjg]

Someone can check this? The warning is VERY annoying.

[msvticket]

/ok-to-test

[msvticket]

/approve

[jenkins-x-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msvticket

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [msvticket]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jrx-sjg]

@hutchic Can you take a look on this?

[hutchic]

@jrx-sjg not really no -- sorry. My time got occupied elsewhere

[jenkins-x-bot]

@hutchic: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pr	ca12c21	link	/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

[jrx-sjg]

Hi @hutchic , the PR build failed because an used import has been left on pkg/plugins/trigger/pull-request.go.

CGO_ENABLED=0 GOOS=linux GOARCH=amd64 GO111MODULE=on go build -ldflags "-X github.com/jenkins-x/lighthouse/pkg/version.Version='-dev+b331b30'" -o bin/webhooks cmd/webhooks/main.go
# github.com/jenkins-x/lighthouse/pkg/plugins/trigger
pkg/plugins/trigger/pull-request.go:31:2: "github.com/pkg/errors" imported and not used
make: *** [Makefile:76: build-webhooks-linux] Error 1
Error: Process completed with exit code 2.

Can you please delete it and commit the changes so the PR can go on?