Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-68740: Support ansible-lint >=6.1.0 warning format #804

Merged
merged 1 commit into from
Jun 12, 2022

Conversation

Tobisaninfo
Copy link
Contributor

Hi,

this pull request adds support for the new ansible-lint (version >= 6.1.0) PEP8 warning format. Further details can be found in https://issues.jenkins.io/browse/JENKINS-68740.

Changes

  • Edited regex to support additional colon in warning
  • Colon is marked as optional (older ansible-lint version (<6.1.0) does not have this colon)
  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Add optional additional colon after linting rule name to regex to support old format (prior ansible-lint 6.1.0) and new format
@codecov
Copy link

codecov bot commented Jun 12, 2022

Codecov Report

Merging #804 (babb012) into master (cef1242) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #804   +/-   ##
=========================================
  Coverage     92.73%   92.73%           
  Complexity     2136     2136           
=========================================
  Files           316      316           
  Lines          5950     5950           
  Branches        599      599           
=========================================
  Hits           5518     5518           
  Misses          264      264           
  Partials        168      168           
Impacted Files Coverage Δ
...u/hm/hafner/analysis/parser/AnsibleLintParser.java 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cef1242...babb012. Read the comment docs.

@uhafner uhafner added the enhancement Enhancement of existing functionality label Jun 12, 2022
Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for fixing it! Good to see that now both formats are supported.

@uhafner uhafner merged commit c47ee7b into jenkinsci:master Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants