Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stylelint as additional alias for the CheckStyle parser #812

Merged
merged 2 commits into from
Jul 10, 2022

Conversation

NotMyFault
Copy link
Member

The change proposed adds a Stylelint checkstyle along the already added checkstyle-like reporters.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did

@NotMyFault NotMyFault changed the title feat: Add Stylelint checkstylr feat: Add Stylelint checkstyle Jul 10, 2022
@codecov
Copy link

codecov bot commented Jul 10, 2022

Codecov Report

Merging #812 (0dede61) into master (2d42aa0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #812   +/-   ##
=========================================
  Coverage     92.76%   92.76%           
- Complexity     2147     2152    +5     
=========================================
  Files           318      319    +1     
  Lines          5968     5974    +6     
  Branches        601      601           
=========================================
+ Hits           5536     5542    +6     
  Misses          264      264           
  Partials        168      168           
Impacted Files Coverage Δ
...du/hm/hafner/analysis/registry/ParserRegistry.java 100.00% <ø> (ø)
.../hafner/analysis/registry/StylelintDescriptor.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d42aa0...0dede61. Read the comment docs.

Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

@uhafner uhafner added the enhancement Enhancement of existing functionality label Jul 10, 2022
@uhafner uhafner changed the title feat: Add Stylelint checkstyle Add Stylelint as additional alias for the CheckStyle parser Jul 10, 2022
@NotMyFault NotMyFault requested a review from uhafner July 10, 2022 15:13
@uhafner uhafner merged commit d9daf37 into jenkinsci:master Jul 10, 2022
@NotMyFault NotMyFault deleted the feat/master/stylelint branch July 14, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants