Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render logs correctly for long running jobs which generate lots of logs #202

Merged
merged 4 commits into from
Sep 1, 2020

Conversation

tszmytka
Copy link
Collaborator

Fixes #200
All is pretty much described in the issue.
The PR adds a way for checking the currently active color map name in the currently running job run.

…job and its color map name. Recognize it while rendering
…is currently running. Use it to render long log. Test
@tszmytka tszmytka added this to the v0.7.3 milestone Aug 29, 2020
@tszmytka tszmytka added the bugfix (release-drafter) label Aug 29, 2020
@tszmytka tszmytka marked this pull request as draft August 30, 2020 21:08
@tszmytka
Copy link
Collaborator Author

The new test is completing fine on my localhost but failing on both CI hosts.
Let me figure out what is going on.

@tszmytka tszmytka marked this pull request as ready for review August 31, 2020 20:12
@tszmytka tszmytka requested a review from dblock August 31, 2020 20:13
@dblock
Copy link
Member

dblock commented Sep 1, 2020

Add an entry to https://github.com/jenkinsci/ansicolor-plugin/blob/master/CHANGELOG.md and this is good to squash-merge, feel free to do it.

Debug test failing on remote CI host

Debug test failing on remote CI host

Debug test failing on remote CI host

Debug test failing on remote CI host

Clean up debugging

Increase lines to make it run longer. Test completes sometimes

Consistently use 'LOGGER'

Document change
@tszmytka tszmytka merged commit 4b172cf into jenkinsci:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix (release-drafter)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raw escape sequences in output while refreshing a long running build
2 participants