Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#223 Work around withMaven step not passing on log line metadata #226

Merged
merged 3 commits into from
May 15, 2021
Merged

#223 Work around withMaven step not passing on log line metadata #226

merged 3 commits into from
May 15, 2021

Conversation

tszmytka
Copy link
Collaborator

@tszmytka tszmytka commented May 13, 2021 •
edited
Loading

Fixes #223

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Link to relevant issues in GitHub or Jira
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@tszmytka tszmytka added the enhancement (release-drafter) label May 13, 2021
@dblock
Copy link
Member

dblock commented May 13, 2021

Needs CHANGELOG

@tszmytka
Copy link
Collaborator Author

CHANGELOG updated

@dblock
Copy link
Member

dblock commented May 15, 2021

Rebase, merge. Looks good.

@dblock dblock merged commit 0d69f83 into jenkinsci:master May 15, 2021
@tszmytka tszmytka deleted the 223-interop-maven branch May 15, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
enhancement (release-drafter)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ansiColor step inside withMaven: coloring is not kept after execution
2 participants
@tszmytka @dblock