Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up build #236

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Clean up build #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<parent>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>4.18</version>
<version>4.51</version>
</parent>

<artifactId>windows-azure-storage</artifactId>
Expand All @@ -16,11 +16,7 @@
<properties>
<changelist>9999-SNAPSHOT</changelist>
<gitHubRepo>jenkinsci/azure-storage-plugin</gitHubRepo>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<jenkins.version>2.277.2</jenkins.version>
<java.level>8</java.level>
<maven.javadoc.skip>true</maven.javadoc.skip>
</properties>

<licenses>
Expand Down Expand Up @@ -118,7 +114,7 @@
<dependency>
<groupId>io.jenkins.tools.bom</groupId>
<artifactId>bom-2.277.x</artifactId>
<version>909.vf028101f1bfa</version>
<version>984.vb5eaac999a7e</version>
<scope>import</scope>
<type>pom</type>
</dependency>
Expand Down
1 change: 0 additions & 1 deletion src/main/java/com/microsoftopentechnologies/windowsazurestorage/helper/AzureUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,6 @@ public static String generateBlobSASURL(
* @param fileName
* @param shareName container name
* @return SAS URL
* @throws Exception
*/
public static String generateFileSASURL(
StorageAccountInfo storageAccount,
Expand Down
2 changes: 0 additions & 2 deletions src/main/java/com/microsoftopentechnologies/windowsazurestorage/helper/CredentialRename.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

package com.microsoftopentechnologies.windowsazurestorage.helper;

import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import org.apache.commons.io.FileUtils;

import java.io.File;
Expand Down Expand Up @@ -90,7 +89,6 @@ public static void renameStorageConfig() throws IOException {
removeFile(backUp.getCanonicalPath());
}

@SuppressFBWarnings("RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE") // Bug in spotbugs for try-with-resources
private static boolean renameNotNeededFor(Path path) throws IOException {
try (Stream<String> stream = Files.lines(path)) {
boolean needRename = stream.anyMatch(s -> s.contains(SOURCE_CONTENT));
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/com/microsoftopentechnologies/windowsazurestorage/Messages.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ WAStoragePublisher_displayName=Upload artifacts to Azure Storage
WAStoragePublisher_build_failed_err=AzureStorage - Build failed, hence canceling the upload of the artifacts \
to Azure storage
WAStoragePublisher_storage_account_err=AzureStorage - Storage account information not found
WAStoragePublisher_container_name_err=AzureStorage - Container name is mi§ssing or not valid
WAStoragePublisher_container_name_err=AzureStorage - Container name is missing or not valid
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lolwut

WAStoragePublisher_filepath_err=AzureStorage - List of files to upload must not be empty
WAStoragePublisher_container_name=AzureStorage - Container name: {0}
WAStoragePublisher_share_name=AzureStorage - share name: {0}
Expand Down