-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JENKINS-47378# Switch to JDK8 and core 2.73.2 #1479
Conversation
Workflow SCM step and Workflow Job can be upgraded too BTW |
@i386 ok will update them. |
I think the |
@fwilhe Thanks for bringing it to attention. Looks like we forgot to change it last time we upgraded core to 2.46.3 as well. cc: @michaelneale |
@i386 @michaelneale We can not use workflow-job > 2.12.2 as these later versions only work with jenkins 2.62 and higher. There are new APIs added in 2.62 that they use so unless we upgrade to LTS 2.73.1 or later we have to stick with workflow-job 2.12.2. |
@vivek ahh gotcha. |
ah I misremembered the workflow-job version |
@michaelneale @imeredith Something strange with ATH test runs. All of these failing tests work fine locally. Most of them are failing with timeout during call to Jenkins APIs. Since I can't reproduce locally, don't know how to go about debugging it. Can you guys try out locally and see if it fails for you? Or if there is something else needs to be changed to upgrade jenkins core?
I suspect something to do with jenkins-client. Calls are timing out during jenkins api calls, e.g. CustomJenkinsServer.deleteUserDomainCredential() possible at |
@vivek https://ci.blueocean.io/job/blueocean/job/task%252FJENKINS-47378_jdk8/14/artifact/acceptance-tests/target/screenshots/io.blueocean.ath.offline.dashboard.DashboardTest_checkExecutorPluginLoaded.png to me implies blue ocean isn't loading properly, or perhaps compatibility with something broke. I am not sure if the hpi sizes are off - if they are it means a bundling problem (ie different from a passing master branch). |
@michaelneale bundling etc. are fine. Try running locally, works great. I suspect some other factor introduced during run on dogfood? Most likely its exposing ATH test flakiness introduced with upgrade to core 2.73.2. |
@vivek that 404 means something isn't loading into the ATH from blue ocean (ie something has broken re backward compatability) - maybe the JDK version on CI is not the same as locally? There hasn't been a change to the environment. |
@michaelneale Right but don't know whats causing because the same test works well locally. Try locally see if it fails, we need to find whats causing this plugin to not load. In other instances its just timeout, maybe related. |
a5eabba
to
fb35f30
Compare
@vivek locally I see problems. Did you try running the whole suite locally? checkExecutorPluginLoaded fails for me the same as CI.
you have to look up the log a bit to see it when it starts the ATH. @imeredith and I looked at this the other day, sometimes errors get swallowed there and things aren't ok. Did you run the whole suite locally? as it isn't starting up correctly in ATH locally for me, I see that error, there is no executor plugin installed etc... so something isn't right. Look for the failure in the log: https://ci.blueocean.io/blue/organizations/jenkins/blueocean/detail/task%2FJENKINS-47378_jdk8/14/artifacts I expect this would be a fairly heavy change, not surprised things arent' smooth. I think the runtime-deps of the ATH will need adjustment, but I can't remember how/where it assembles the plugins. |
@michaelneale thanks, ok had to scroll up a bit to notice that error. Probably my local ath had stale bit and for some reason running with |
@michaelneale now one test is failing, but it passes for me locally. I am running it as:
However it failed in CI with this error:
We should re-write these tests to use API to create these folders, no point running selenium test on classic UI, thats not something we intend to test anyways. |
That could well be legitimate. It stresses the encoding of things.
On Fri, 13 Oct 2017 at 6:42 pm, Vivek Pandey ***@***.***> wrote:
@michaelneale <https://github.com/michaelneale> now one test is failing,
but it passes for me locally. I am running it as:
nightwatch src/test/js/edgeCases/folder.js
However it failed in CI with this error:
&#27;[0;31m???&#27;[0m Timed out while waiting for element <form[name="config"]> to be present for 20000 milliseconds. &#27;[1;37m - expected &#27;[0;32m"found"&#27;[0m&#27;[0m but got: &#27;[0;31m"not found"&#27;[0m
06:58:12 INFO - &#27;[0;90m at createFolder (/home/jenkins/slave/workspace/ean_task_JENKINS-47378_jdk8-YUP4IDGCYBA4YZOHDUPWFZGBV4IP4AOMCUCCX6C5IRJCLP3HYONA/acceptance-tests/src/main/js/page_objects/classic_jenkins/folderCreate.js:57:18)
06:58:12 INFO - at Object.module.exports.commands.createFolders (/home/jenkins/slave/workspace/ean_task_JENKINS-47378_jdk8-YUP4IDGCYBA4YZOHDUPWFZGBV4IP4AOMCUCCX6C5IRJCLP3HYONA/acceptance-tests/src/main/js/page_objects/classic_jenkins/folderCreate.js:80:13)
06:58:12 INFO - at Object.module.exports.step 01 (/home/jenkins/slave/workspace/ean_task_JENKINS-47378_jdk8-YUP4IDGCYBA4YZOHDUPWFZGBV4IP4AOMCUCCX6C5IRJCLP3HYONA/acceptance-tests/src/test/js/edgeCases/folder.js:60:21)&#27;[0m
We should re-write these tests to use API to create these folders, no
point running selenium test on classic UI, thats not something we intend to
test anyways.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1479 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAA6gGc3rMnA1UChPbJn5iaEzpasmyfbks5srxR5gaJpZM4P1RA6>
.
--
…--
Regards,
Michael Neale
(twitter: @michaelneale, skype: michael_d_neale)
Cell: +61 423175597
Cofounder & Engineering Manager.
|
@michaelneale It looks legit but nothing to do with encoded folder names. Its failing doing selenium testing of classic UI to create folder. Please give it try your Monday morning, see if you can reproduce it because I can't reproduce it locally. |
@vivek yes that probably could explain it. Creating jobs should be via other means. This change will take quite a lot more work perhaps than expected. Is this urgent? |
@michaelneale yeah I think we must do it first thing if we want to switch to jdk8 for 1.4, of course if there is something urgent then we can do this later. By postponing it won’t buy anything, will only delay problems to be fixed later. Also we want to code in Java 8:) |
@michaelneale work wise, disagree it needs lots of work. we are pretty close, the last set of ath nightwatch tests are failing. Matter of figuring why. It works fine locally so must be something minor somewhere. |
@vivek ok cool, yeah just wasn't sure if this would be one of those huge time sinks, but if you sound confident, that is good ;) FWIW that edgeCases/folder.js test passes for me locally too - try it again? Otherwise my guess is some encoding thing (although the missing form element usually points to classic behavior) |
@michaelneale replayed. I don't know how big this issue is, fact that it works locally for us, could be something in CI env causing it. I will keep it going in parallel... |
So not sure what that is about - only thing different would be that the JDK versions might not be exactly the same locally, or the time taken to load that form (or something like that) - but it is odd. Consistently fails there. |
d622238
to
cf627fb
Compare
@michaelneale yeah not up to date with master. Ok, will wait for #1484 to merge. |
Also avoids race condition where CPS execution is interrupted while its in the middle of writing node data to xstream resulting in result reported as FAILURE due to underlying IOException vs expected ABORTED.
… in the right place
496b2e4
to
a6d57a7
Compare
@michaelneale rebates on latest mater is green. I think master is stable now and it can be merged? |
" sh('sleep 60') " + | ||
" stage ('Test1'); " + | ||
" stage ('Build'); " + | ||
" semaphore 's' " + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat
@@ -16,9 +16,9 @@ | |||
<name>Blue Ocean Parent</name> | |||
|
|||
<properties> | |||
<java.level>7</java.level> | |||
<java.level>8</java.level> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we're fully Java 8 now? can use all java 8 features?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, once it merges java8 it is:)
@@ -490,6 +478,13 @@ | |||
<groupId>org.jenkins-ci.plugins</groupId> | |||
<artifactId>git</artifactId> | |||
<version>${git.version}</version> | |||
<exclusions> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Annoying to have to exclude this everywhere...
if (task.getCauseOfBlockage() != null) { | ||
cause = task.getCauseOfBlockage().getShortDescription(); | ||
CauseOfBlockage causeOfBlockage = task.getCauseOfBlockage(); | ||
if ( causeOfBlockage != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: whitespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can we finally use Java 8 features?
* JENKINS-47378# Switch to JDK8 and core 2.60.3 * Updated scm sep and workflow job plugins * workflow-job version > 2.12.2 is compatible with core 2.62 and higher * Test fix to reliably stop a pipeline run Also avoids race condition where CPS execution is interrupted while its in the middle of writing node data to xstream resulting in result reported as FAILURE due to underlying IOException vs expected ABORTED. * Bump up core version to 2.60.3 for ATH as well * Changed jenkins core versions for ath * Use 2.73.2 LTS instead * Findbugs fixes * Log error message in ath test * Fix build failure in ath runtime-plugins module and upgrade them to 2.73.2 * Added 10 more sec before timeout and some logging * Increasing timeout to 1 min, lets see if its just slow load of config page. * enable nightwatch screenshots by placing "screenshots" config element in the right place * suppress nightwatch screenshot during "command errors" since these seem superfluous * Set utf-8 locale in the ubuntu container * locale-gen and then set locale * install locales
Description
Upgrade Java level to JDK8 and Jenkins core to 2.60.3.
See JENKINS-47378.
Submitter checklist
Reviewer checklist