Bump configuration-as-code-plugin.version from 1466.v2d4119502006 to 1511.vb_f985b_894e40 in /bom-weekly #1277
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps `configuration-as-code-plugin.version` from 1466.v2d4119502006 to 1511.vb_f985b_894e40. Updates `configuration-as-code` from 1466.v2d4119502006 to 1511.vb_f985b_894e40 - [Release notes](https://github.com/jenkinsci/configuration-as-code-plugin/releases) - [Commits](https://github.com/jenkinsci/configuration-as-code-plugin/commits) Updates `test-harness` from 1466.v2d4119502006 to 1511.vb_f985b_894e40 - [Release notes](https://github.com/jenkinsci/configuration-as-code-plugin/releases) - [Commits](https://github.com/jenkinsci/configuration-as-code-plugin/commits) --- updated-dependencies: - dependency-name: io.jenkins:configuration-as-code dependency-type: direct:production - dependency-name: io.jenkins.configuration-as-code:test-harness dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
so we either remove it from bom or temporarily add it to the sample plugin? |
|
It is not easier to merge the two PR together ? :) |
doesn't the other PR just need jcasc bumped? the commons-lang3 thing is just an annoyance here because transitive deps are not supposed to be explicitly listed in the sample plugins because it doesn't prove that deps align properly. |
|
Wouldn't mina-sshd pull in the dependency and solve the issue? |
it doesn't depend on it to my knowledge |
|
One of your CI runs failed on this pull request, so Dependabot won't merge it. Dependabot will still automatically merge this pull request if you amend it and your tests pass. |
| @@ -74,6 +74,16 @@ | |||
| <artifactId>checks-api</artifactId> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>io.jenkins.plugins</groupId> | |||
| <artifactId>commons-lang3-api</artifactId> | |||
There was a problem hiding this comment.
Not great (as mentioned, the idea is that transitive deps should be clean) but looks like the best we can do for now.
There was a problem hiding this comment.
its all temporary. We can cleanup :)
|
This PR has already been merged! 🎉 |
dependabot
bot
deleted the
dependabot/maven/bom-weekly/configuration-as-code-plugin.version-1511.vb_f985b_894e40
branch
Bumps
configuration-as-code-plugin.versionfrom 1466.v2d4119502006 to 1511.vb_f985b_894e40.Updates
configuration-as-codefrom 1466.v2d4119502006 to 1511.vb_f985b_894e40Release notes
Sourced from configuration-as-code's releases.
... (truncated)
Commits
Updates
test-harnessfrom 1466.v2d4119502006 to 1511.vb_f985b_894e40Release notes
Sourced from test-harness's releases.
... (truncated)
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot will merge this PR once CI passes on it, as requested by @jetersen.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)