Introduce EdDSA-api plugin #3230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as mentioned in the upstream PR that attempted to do this unconditionally this is broken by design. the JTH and tests assume that the classpath is correctly setup however it is not, as demonstrated in the prior commit. According to Jenkins there is a plugin installed (trilead-api) because it is in the megawar, however its classess are not in the flat classpath used by JenkinsRule and thus breakage ensues. ref: jenkinsci/plugin-compat-tester#470 (comment)
alecharp
approved these changes
May 23, 2024
I expect issues similar to this (for which an issue will be filed along with a fix) |
|
Just as you said, it fails exactly where you said it would. |
auto-merge was automatically disabled
May 23, 2024 11:18
Head branch was pushed to by a user without write access
jglick
previously requested changes
May 23, 2024
|
The particular error mentioned in #3231 could be solved in |
MarkEWaite
approved these changes
May 29, 2024
jglick
approved these changes
May 29, 2024
| @@ -33,6 +33,10 @@ | |||
| <groupId>io.jenkins.plugins</groupId> | |||
| <artifactId>byte-buddy-api</artifactId> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>io.jenkins.plugins</groupId> | |||
| <artifactId>eddsa-api</artifactId> | |||
There was a problem hiding this comment.
Note: the original intent of this file was to include only dependencies that were actually used “naturally”, not transitive deps. This was never mechanically enforced, though, and has proven difficult to manage: #683
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not pass the Fat War to the JTH to avoid random issues with plugins being present (yet missing classes) that should not be present, or present and unexpected (ie failing when a given system property is set by JTH)Testing done
None, to be tested in CI
Submitter checklist