Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more spotbugs checks #45

Merged
merged 4 commits into from
Nov 8, 2022
Merged

Add more spotbugs checks #45

merged 4 commits into from
Nov 8, 2022

Conversation

MarkEWaite
Copy link
Contributor

Add more spotbugs checks

  • Avoid unnecessary null pointer check
  • Avoid unnecessary null pointer check
  • Enable more spotbugs checks

Code changes and exclusions

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

gounthar
gounthar approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@gounthar gounthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks. 👍

@MarkEWaite MarkEWaite merged commit 91d095e into jenkinsci:master Nov 8, 2022
@MarkEWaite MarkEWaite added the chore Maintenance label Nov 8, 2022
@MarkEWaite MarkEWaite deleted the add-spotbugs-checks branch November 8, 2022 13:07
@MarkEWaite MarkEWaite mentioned this pull request Aug 5, 2023
Merged
6 tasks
MarkEWaite added a commit to MarkEWaite/repository-permissions-updater that referenced this pull request Aug 5, 2023
@MarkEWaite
Add markewaite as a conditional-buildstep maintainer
267f1a3 
I've contributed several pull requests to the plugin, including:

* jenkinsci/conditional-buildstep-plugin#46
* jenkinsci/conditional-buildstep-plugin#47
* jenkinsci/conditional-buildstep-plugin#38
* jenkinsci/conditional-buildstep-plugin#48
* jenkinsci/conditional-buildstep-plugin#45
* jenkinsci/conditional-buildstep-plugin#44

I already have permission on the GitHub repository and have merged
several pull requests.

I'd like release permissions so that the plugin can be built and a new
release can be included in the plugin bill of materials.  Plugin BOM
pull request is:

* jenkinsci/bom#2224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gounthar gounthar gounthar approved these changes

Assignees
No one assigned
Labels
chore Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkEWaite @gounthar