Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forward compatibility for core dialogs #286

Merged
merged 1 commit into from
Jul 22, 2023

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Jul 22, 2023

Change jenkinsci/jenkins#7938 released with 2.415 introduces native dialogs as replacement of browser dialogs. Make the tests work with both variants.

Testing done

run tests against 2.414 and 2.415 and both succeeded

Submitter checklist

Change jenkinsci/jenkins#7938 released with
2.415 introduces native dialogs as replacement of browser dialogs.
Make the tests work with both variants.
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

@MarkEWaite
Copy link
Contributor

@rsandell could you label this pull request as developer and merge it so that we can update the Jenkins plugin bill of materials to include the latest release?

If the merge can't happen before Monday, I'll add a temporary exclusion to the bom tests so that it will ignore the test failures.

MarkEWaite added a commit to MarkEWaite/bom that referenced this pull request Jul 22, 2023
Tests fail with Jenkins 2.415

PR jenkinsci/config-file-provider-plugin#286

Confirmed that PR works, do not delay BOM release for test fix
MarkEWaite added a commit to jenkinsci/bom that referenced this pull request Jul 22, 2023
Tests fail with Jenkins 2.415

PR jenkinsci/config-file-provider-plugin#286

Confirmed that PR works, do not delay BOM release for test fix
@rsandell rsandell added this pull request to the merge queue Jul 22, 2023
Merged via the queue into jenkinsci:master with commit a544a62 Jul 22, 2023
13 checks passed
MarkEWaite added a commit to MarkEWaite/bom that referenced this pull request Jul 22, 2023
MarkEWaite added a commit to jenkinsci/bom that referenced this pull request Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants