forward compatibility for core dialogs #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change jenkinsci/jenkins#7938 released with 2.415 introduces native dialogs as replacement of browser dialogs. Make the tests work with both variants.
6 tasks
|
@rsandell could you label this pull request as If the merge can't happen before Monday, I'll add a temporary exclusion to the bom tests so that it will ignore the test failures. |
6 tasks
MarkEWaite
added a commit
to MarkEWaite/bom
that referenced
this pull request
Jul 22, 2023
Tests fail with Jenkins 2.415 PR jenkinsci/config-file-provider-plugin#286 Confirmed that PR works, do not delay BOM release for test fix
MarkEWaite
added a commit
to jenkinsci/bom
that referenced
this pull request
Jul 22, 2023
Tests fail with Jenkins 2.415 PR jenkinsci/config-file-provider-plugin#286 Confirmed that PR works, do not delay BOM release for test fix
rsandell
approved these changes
Jul 22, 2023
MarkEWaite
added a commit
to MarkEWaite/bom
that referenced
this pull request
Jul 22, 2023
Fixed issue jenkinsci#2274 with pull request jenkinsci#2276 jenkinsci/config-file-provider-plugin#286 fixed it thanks to @mawinter69 and @rsandell. This reverts commit 8fe50be.
6 tasks
MarkEWaite
added a commit
to jenkinsci/bom
that referenced
this pull request
Jul 22, 2023
Fixed issue #2274 with pull request #2276 jenkinsci/config-file-provider-plugin#286 fixed it thanks to @mawinter69 and @rsandell. This reverts commit 8fe50be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change jenkinsci/jenkins#7938 released with 2.415 introduces native dialogs as replacement of browser dialogs. Make the tests work with both variants.
Testing done
run tests against 2.414 and 2.415 and both succeeded
Submitter checklist