Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless broken "Add" button on credentials-select-control. #373

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jamie-pate
Copy link

I don't know if there is a way to get a 'data-url' into the template to actually fix this button.

See this change that broke it: 9c5bb72#diff-45693b8474f3341b5d603b463cd4c10f4ec301a1c8c1c89b67034ba81056dfc9R44

  • [x ] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [x ] Ensure that the pull request title represents the desired changelog entry
  • [x ] Please describe what you did
  • [? ] Link to relevant issues in GitHub or Jira (there is no issues tab on github, and where is this Jira?)
  • [x ] Link to relevant pull requests, esp. upstream and downstream changes
  • [? ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

I don't know if there is a way to get a 'data-url' into the template to actually fix this button.

See this change that broke it: jenkinsci@9c5bb72#diff-45693b8474f3341b5d603b463cd4c10f4ec301a1c8c1c89b67034ba81056dfc9R44
@jtnord
Copy link
Member

jtnord commented Dec 14, 2022

can you describe in detail what doesn;t work or why it is broken? Perhaps a Jira issue?

@jamie-pate
Copy link
Author

It looks like it was just left out in a refactor but never removed... It just does nothing

@jtnord
Copy link
Member

jtnord commented Oct 2, 2023

<button class="credentials-add jenkins-!-margin-top-2">
<l:icon src="symbol-add"/>
${%Add}
</button>
?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants