-
-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup: correct unused code #428
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
approved these changes
May 19, 2023
Using auto-merge to ensure cleaned up elements are effect-less |
dduportal
changed the title
Cleanup: correct unused code
Cleanup: correct unused code - fixup of #409
May 21, 2023
dduportal
changed the title
Cleanup: correct unused code - fixup of #409
Cleanup: correct unused code
May 21, 2023
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 27, 2023
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 27, 2023
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Jan 11, 2024
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pairing session with @dduportal to remove some unused code.
Replaced
NULL
with$null
inbuild.ps1
and removed an unusedFROM
from the Alpine Dockerfile.Testing done
We verified that the only
ALPINE_TAG
taken into account is the first one, before the firstFROM
.Submitter checklist
Link to relevant issues in GitHub or JiraLink to relevant pull requests, esp. upstream and downstream changes