Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: correct unused code #428

Merged
merged 3 commits into from
May 19, 2023
Merged

Conversation

gounthar
Copy link
Contributor

Pairing session with @dduportal to remove some unused code.
Replaced NULL with $null in build.ps1 and removed an unused FROM from the Alpine Dockerfile.

Testing done

We verified that the only ALPINE_TAG taken into account is the first one, before the first FROM.

docker buildx bake alpine_jdk17 --load

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@gounthar gounthar marked this pull request as ready for review May 19, 2023 17:27
@gounthar gounthar requested a review from a team as a code owner May 19, 2023 17:27
@dduportal dduportal enabled auto-merge May 19, 2023 17:28
@dduportal
Copy link
Contributor

Using auto-merge to ensure cleaned up elements are effect-less

@dduportal dduportal merged commit 5033123 into jenkinsci:master May 19, 2023
@gounthar gounthar deleted the chore/cleanup branch May 19, 2023 17:46
@dduportal dduportal changed the title Cleanup: correct unused code Cleanup: correct unused code - fixup of #409 May 21, 2023
@dduportal dduportal changed the title Cleanup: correct unused code - fixup of #409 Cleanup: correct unused code May 21, 2023
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 27, 2023
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 27, 2023
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Jan 11, 2024
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants