chore(build): activate failFast for parallel stages

[lemeurherve]

This PR activates failFast so the build stop whenever there is an error instead of waiting for the completion of every stage.

Testing done

Replayed with a voluntary error in the linux stage: https://ci.jenkins.io/job/Packaging/job/docker-agent/job/PR-446/3/

diff

--- old/Jenkinsfile
+++ new/Jenkinsfile
@@ -8,6 +8,7 @@
 
     stages {
         stage('Build') {
+            failFast true
             parallel {
                 stage('Windows') {
                     agent {
@@ -71,8 +72,9 @@
                         stage('Prepare Docker') {
                             steps {
                                 sh '''
-                                docker buildx create --use
-                                docker run --rm --privileged multiarch/qemu-user-static --reset -p yes
+                                exit 1
+                                // docker buildx create --use
+                                // docker run --rm --privileged multiarch/qemu-user-static --reset -p yes
                                 '''
                             }
                         }

Submitter checklist

Beta Give feedback

1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
2. Ensure that the pull request title represents the desired changelog entry
3. Please describe what you did
4. Link to relevant issues in GitHub or Jira
5. Link to relevant pull requests, esp. upstream and downstream changes
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

[MarkEWaite]

I've generally preferred to not failFast because it often means that I need to perform multiple runs in order to detect all the issues. Is there some benefit from failFast that I'm missing?

[lemeurherve]

I guess it's a personal preference indeed.

As I now try to do smaller atomic pull requests there are less changes in each of them, and prefer the build to fail quickly instead of letting resources be wasted or cancelling builds manually.

I don't attach a lot of importance to this change, fine to me if this PR is closed.

[MarkEWaite]

I guess it's a personal preference indeed.

No objection from me if it is merged. I was curious and you've answered my question well. Approved to merge once CI passes.