Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inbound agent pictures #768

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

MarkEWaite
Copy link
Contributor

Add pictures for inbound agent documentation

Fix #767

From https://github.com/jenkinsci/docker-inbound-agent.git

Testing done

Confirmed that the images render as expected in the pull request.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@MarkEWaite MarkEWaite requested a review from a team as a code owner March 13, 2024 00:29
@MarkEWaite MarkEWaite enabled auto-merge (squash) March 13, 2024 00:33
Copy link
Member

@lemeurherve lemeurherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch thanks!

Missed this folder while merging both repos in #570

@MarkEWaite
Copy link
Contributor Author

@lemeurherve thanks! I skipped one image (0.jpg) that was in the root directory and seemed to be unused. If we discover a location where it is used, we can add it to the repository as well.

@MarkEWaite MarkEWaite merged commit 02ea0ef into jenkinsci:master Mar 13, 2024
10 checks passed
@MarkEWaite MarkEWaite deleted the add-images-for-docs branch March 16, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images are missing from the inbound-agent README
2 participants