This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
chore(linux tests) apply shellcheck and fix concurency issues #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
force-pushed
the
chore/tests/shellcheck
branch
from
3401d6f
to
14d3104
Compare
Signed-off-by: Damien Duportal <[email protected]>
dduportal
force-pushed
the
chore/tests/shellcheck
branch
from
2c5e591
to
4dbd95b
Compare
Signed-off-by: Damien Duportal <[email protected]>
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
…uportal/chore/tests/shellcheck chore(linux tests) apply shellcheck and fix concurency issues
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
…uportal/chore/tests/shellcheck chore(linux tests) apply shellcheck and fix concurency issues
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
…uportal/chore/tests/shellcheck chore(linux tests) apply shellcheck and fix concurency issues
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
…uportal/chore/tests/shellcheck chore(linux tests) apply shellcheck and fix concurency issues
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
…uportal/chore/tests/shellcheck chore(linux tests) apply shellcheck and fix concurency issues
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Jan 12, 2024
…chore/tests/shellcheck chore(linux tests) apply shellcheck and fix concurency issues
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging #296 (why are the Linux tests failing for JDK17 Debian only? Why not reproducible locally?) I realized that the bats test was not ready for concurent executions (which is the case in the CI).
This PR aims at fixing this by:
localshell keyword to mark variables local to function and avoid scope issues