This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 527
chore(linux) factorize JDK specification to docker bakefile #347
Merged
dduportal
merged 2 commits into
jenkinsci:master
from
dduportal:chore/factorize-Dockerfile-per-JDK
May 19, 2023
Merged
chore(linux) factorize JDK specification to docker bakefile #347
dduportal
merged 2 commits into
jenkinsci:master
from
dduportal:chore/factorize-Dockerfile-per-JDK
May 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Damien Duportal <[email protected]>
dduportal
force-pushed
the
chore/factorize-Dockerfile-per-JDK
branch
3 times, most recently
from
May 18, 2023 14:46
9768b04
to
86a78c1
Compare
Signed-off-by: Damien Duportal <[email protected]>
dduportal
force-pushed
the
chore/factorize-Dockerfile-per-JDK
branch
from
May 18, 2023 15:11
86a78c1
to
8f9e77d
Compare
MarkEWaite
approved these changes
May 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much!
lemeurherve
pushed a commit
to lemeurherve/jenkinsci-docker-inbound-agent
that referenced
this pull request
Nov 19, 2023
…211.0.109768 in /11/archlinux (jenkinsci#347) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
…uportal/chore/factorize-Dockerfile-per-JDK chore(linux) factorize JDK specification to docker bakefile
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
…uportal/chore/factorize-Dockerfile-per-JDK chore(linux) factorize JDK specification to docker bakefile
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
…uportal/chore/factorize-Dockerfile-per-JDK chore(linux) factorize JDK specification to docker bakefile
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
…uportal/chore/factorize-Dockerfile-per-JDK chore(linux) factorize JDK specification to docker bakefile
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
…uportal/chore/factorize-Dockerfile-per-JDK chore(linux) factorize JDK specification to docker bakefile
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
…uportal/chore/factorize-Dockerfile-per-JDK chore(linux) factorize JDK specification to docker bakefile
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Jan 12, 2024
…chore/factorize-Dockerfile-per-JDK chore(linux) factorize JDK specification to docker bakefile
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twin of jenkinsci/docker-agent#409
This pull request aims at factorizing the image definitions (
Dockerfile
s) to avoid duplicating code between JDK versions.Until now, changing an element in any of the images which have both JDK11 and JDK17 definitions were subject to a risk of shift if the 2nd image is forgotten.
How does it work?
11/
and17/
, representing the major JDK version, are removedFROM
directives) needs it to check the paraent image from jenkinsci/docker-agentDockerfile
s do have a default major version defined to ensure it's buildable "as it" (e.g. without Docker BuildX and its bake file). The proposed default is17
docker compose
is not used for the Windows images (tooling is a bit different than jenkinsci/docker-agent). Subject of a future PR (or merging with jenkinsci/docker-agent)Testing done
Submitter checklist