Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#936 Added tzdata package #937

Merged
merged 5 commits into from
Apr 22, 2020
Merged

#936 Added tzdata package #937

merged 5 commits into from
Apr 22, 2020

Conversation

krufab
Copy link

@krufab krufab commented Mar 28, 2020

So that now it handles correctly the TZ variable:

Successfully built d4dfd7e46080
docker run --rm -it -e "TZ=Europe/Luxembourg" d4dfd7e46080 date
Sat Mar 28 11:59:12 CET 2020
docker run --rm -it -e "TZ=Europe/London" d4dfd7e46080 date
Sat Mar 28 10:59:20 GMT 2020

Fixes #936

jenkinsci#936 Added tzdata package
164cf03 
Signed-off-by: Fabio Kruger <[email protected]>
@krufab krufab requested a review from a team as a code owner March 28, 2020 11:07
oleg-nenashev
oleg-nenashev approved these changes Mar 28, 2020
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for adding it by default, timezones are important for the master

MarkEWaite
MarkEWaite approved these changes Mar 28, 2020
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much.

Is a test of the fix feasible and easy enough to justify creating it?

@krufab
Copy link
Author

krufab commented Mar 29, 2020

I can try to add some test code

@slide
Copy link
Member

slide commented Apr 22, 2020

Looks like there is a test failure

@krufab
Copy link
Author

krufab commented Apr 22, 2020

The last run seems ok
https://ci.jenkins.io/blue/organizations/jenkins/Packaging%2Fdocker/detail/PR-937/103/pipeline

@slide slide merged commit b3fe176 into jenkinsci:master Apr 22, 2020
@krufab krufab mentioned this pull request Apr 25, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slide slide slide approved these changes

@MarkEWaite MarkEWaite MarkEWaite approved these changes

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alpine misses the tzdata package and does not handle timezone correctly
4 participants
@krufab @slide @MarkEWaite @oleg-nenashev