Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix character set tests #1020

Merged
merged 3 commits into from
Jun 7, 2023
Merged

Fix character set tests #1020

merged 3 commits into from
Jun 7, 2023

Commits on Jun 7, 2023

  1. Use collector consistently in the maintenance test 

    Previous commit mistakenly used an assertion directly when it should
have used a collector so that the other assertions in the test would
be checked
    @MarkEWaite
    MarkEWaite committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    ac78ef6 View commit details
    Browse the repository at this point in the history

  2. Set file encoding for tests 

    Fix failing tests on Windows

Revert e69456b
    @MarkEWaite
    MarkEWaite committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    4351743 View commit details
    Browse the repository at this point in the history

  3. Remove flawed character set assertion 

    Impressive the number of ways the assertions were wrong

Simplifies tests
    @MarkEWaite
    MarkEWaite committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    18887d6 View commit details
    Browse the repository at this point in the history