Use proxy.getSecretPassword(), not deprecated proxy.getPassword() #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to @StefanSpieker for the pointer to https://ci.jenkins.io/job/Reporting/job/deprecated-usage-in-plugins/ where it shows that proxy.getPassword() is the only deprecated core API used in the git client plugin. Easy to fix. Not tested by automation. Tested interactively by temporarily adding a logging statement to report the value of userInfo after the assignment. I defined a proxy in the "Advanced settings" of the plugin manager page, then attempted to clone a git repository over https. The logging statement displayed the expected value in the userInfo string. I removed the temporary logging statement.
MarkEWaite
added
the
chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use proxy.getSecretPassword(), not deprecated proxy.getPassword()
Thanks to @StefanSpieker for the pointer to the deprecated core API usage report where it shows that
proxy.getPassword()is the only deprecated core API used in the git client plugin. Easy to fix.Not tested by automation. Adding useful proxy configuration tests is beyond the scope of this pull request.
Tested interactively by temporarily adding a logging statement to report the value of
userInfoafter the assignment. I defined a proxy in the "Advanced settings" of the plugin manager page, then attempted to clone a git repository over https. The logging statement displayed the expected value in the userInfo string. I removed the temporary logging statement.Checklist
Types of changes