Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate hashCode with arguments that are consistent with equals #1097

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Calculate hashCode with arguments that are consistent with equals #1097

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2b8349
Used Objects.hash as a better practice
AniketNS Jan 15, 2024
8aeeb2a
Used String.format for better consistency
AniketNS Jan 15, 2024
85e2bee
Merge branch 'master' into git-client
MarkEWaite Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/hudson/plugins/git/Branch.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ private static String strip(String name) {
*/
@Override
public String toString() {
return "Branch " + name + "(" + getSHA1String() + ")";
return String.format("Branch %s(%s)", name, getSHA1String());
}

/**
Expand All @@ -50,7 +50,7 @@ public String toString() {
*/
@Override
public int hashCode() {
return super.hashCode();
return Objects.hash(name, sha1);
MarkEWaite marked this conversation as resolved.
Show resolved Hide resolved
}

/**
Expand Down
Loading