Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated getPassword() with getSecretPassword() #1189

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Replace deprecated getPassword() with getSecretPassword() #1189

merged 1 commit into from
Sep 18, 2024

Conversation

MarkEWaite
Copy link
Contributor

Replace deprecated getPassword() with getSecretPassword()

Also replaces a StringUtils use with a Java String call.

Testing done

Confirmed that automated tests pass.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@MarkEWaite
Replace deprecated getPassword() with getSecretPassword()
f92c745 
Also replaces a StringUtils use with a Java String call.
@MarkEWaite MarkEWaite requested a review from a team as a code owner September 17, 2024 01:47
@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Sep 17, 2024
@MarkEWaite MarkEWaite merged commit 69ef499 into jenkinsci:master Sep 18, 2024
17 checks passed
@MarkEWaite MarkEWaite deleted the replace-getPassword-with-getSecretPassword branch September 18, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarkEWaite