JENKINS-65315: SubmoduleOption: resolve env vars in reference path #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On contrary to Freestyle projects' getEnvironment, WorkflowRun.getEnvironment doesn't provide node-specific environment variables as it can have multiple node blocks in parallel. So I suggest to pick up envvars just in place. See also jenkinsci#575
|
Tests are failing, but I don't know what to do about the "Jenkins.instance is missing. Read the documentation of Jenkins.getInstanceOrNull to see what you are doing wrong.". Even after reading the documentation of Jenkins.getInstanceOrNull I have no clue. If somebody can point me to the right direction this would be very helpful. |
11 tasks
can you please give a more in depth explanation? Is the change not working for you? |
…les-not-resolved-in-submodules
…les-not-resolved-in-submodules
|
Unfortunately, some tests are still failing after merging the latest master into my branch. I still do not understand what the system is trying to tell me and how to fix the issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-65315 - Resolve environment variables in SubmoduleOption reference path
On contrary to Freestyle projects' getEnvironment, WorkflowRun.getEnvironment doesn't provide node-specific environment variables as it can have multiple node blocks in parallel. So I suggest to pick up envvars just in place.
See also #575 where this had already been done for CloneOption
Checklist
Types of changes