Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not assume HttpResponse is a functional interface #1590

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

basil
Copy link
Member

@basil basil commented Jun 4, 2024

It is right now, but it won't be in the future when a second compatibility method is added to it for EE 9.

Testing done

Passed in EE 8 and EE 9.

@basil basil added the chore Reduces maintenance effort by changes not directly visible to users label Jun 4, 2024
@basil basil requested a review from a team as a code owner June 4, 2024 01:13
@MarkEWaite MarkEWaite enabled auto-merge (squash) June 4, 2024 01:21
@MarkEWaite MarkEWaite merged commit 18933cd into jenkinsci:master Jun 4, 2024
15 checks passed
MarkEWaite added a commit to MarkEWaite/docker-lfs that referenced this pull request Jul 29, 2024
Incremental that includes:

* Use poll env when checking for ls-remote branches
  jenkinsci/git-plugin#1511

* Optionally report the most recent commit as the changelog of a new build
  jenkinsci/git-plugin#1565
  https://issues.jenkins.io/browse/JENKINS-4162
  https://issues.jenkins.io/browse/JENKINS-14138
  https://issues.jenkins.io/browse/JENKINS-26354
  https://issues.jenkins.io/browse/JENKINS-68030

* Generate and revoke access tokens with standard UI components
  jenkinsci/git-plugin#1597

* Do not assume HttpResponse is a functional interface
  jenkinsci/git-plugin#1590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants