Fix release versioning + incremental builds #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a commit for letting the status checks fail.
justusbunsi
changed the title
|
@lafriks The new behavior can be seen at my fork of this plugin: Workflow in action | Releases. |
justusbunsi
changed the title
|
Nice work! |
lafriks
approved these changes
Nov 21, 2021
viceice
added a commit
to visualon/jenkins-gitea-plugin
that referenced
this pull request
Nov 24, 2021
* Enable cd workflow (#35) * Enable cd workflow Signed-off-by: Steven Kriegler <[email protected]> * Add missing GitHub workflow Signed-off-by: Steven Kriegler <[email protected]> * Update .github/workflows/cd.yaml Co-authored-by: Lauris BH <[email protected]> * Switch back to classic version syntax Co-authored-by: Lauris BH <[email protected]> * Bump version to 1.5.0 (jenkinsci#42) Additionally: Fix tag/release template to match previous releases * Fix release versioning + incremental builds (jenkinsci#43) * Add alt-texts to badges This is a commit for letting the status checks fail. * Lower the release version * Re-Add changelist to version * Opt-out incremental suffix during release See: jenkins-infra/jenkins-maven-cd-action#13 * Auto-incrementalify after release * Fix JENKINS-67068 (jenkinsci#44) As a result of PR #29 it happens that some users cannot fetch branches with slashes in their names anymore. Regression from: JENKINS-65796 Co-authored-by: Steven <[email protected]> Co-authored-by: Lauris BH <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last Pull Request broke the incremental builds whilst trying to fix the release tagging/deploy syntax.
The used workflow to deploy the artifact and create a tag + release on GitHub does not support a clean version such as
1.4.0instead of1.4.0-rc..... This is due to the hardcoded-Dset.changelistflag which does not allow skipping the suffix.As the Gitea plugin should have clean release names, I switched to my fork where this feature is implemented. We can use it as long as the upstream PR for that workflow is not merged.
In addition to that, I've came to the conclusion that it wouldn't be wise to skip all the interim versions between 1.4.0 and 1.5.0. Why should we do this. So back to 1.4.1. 😄
We now have a fully automated release on button click (workflow_dispatch). After releasing the current version, the workflow also bumps the incremental/patch version to the next higher version. If there is a need to increase the minor version, we'd need to do it manually.
The only thing I couldn't get working is the
gitea-prefix for tags and thevprefix on release subjects. But I think the current way is totally fine.