Let GitHubAppCredentials on an agent just delegate to the master #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not at all sure that this would work, since |
bitwiseman
reviewed
Aug 20, 2020
| return clone; | ||
| } | ||
|
|
||
| return ch.export(StandardUsernamePasswordCredentials.class, this); |
There was a problem hiding this comment.
@jglick
Why is this a StandardUsernamePasswordCredentials instead of a GitHubAppCredentials? Less class loading?
There was a problem hiding this comment.
You pass the interface type which defines the methods you actually expect something to call.
There was a problem hiding this comment.
Ah, I should RTFM. Sorry. :)
|
While this is simpler, it is also probably unreliable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested alternative to #302 which might solve some issues like #326 is also attempting to.