Simplify jelly pages by removing divBasedFormLayout logic #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the plugin requires a Jenkins version newer than 2.277.1, there is no need for the divBasedFormLayout logic in the jelly forms.
|
@jmMeessen and @gounthar I will add this step to the "Improve a plugin" tutorial after I return from vacation. The step is useful and reduces the maintenance burden of a plugin. It requires a little more thought and analysis than some of the earliest steps and may appeal to those who want something a little more challenging. Eventually I think that we'll want to add a step to modernize user interface components in plugins by using the guidance from the Jenkins design library as can be seen on weekly.ci.jenkins.io. |
|
Confirmed with interactive testing that the modified form displays as expected and remembers changes made in the form. Ready to merge once CI passes. |
MarkEWaite
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify jelly pages by removing divBasedFormLayout conditionals
Now that the plugin requires a Jenkins version newer than 2.277.1, there is no need for the divBasedFormLayout logic in the jelly forms.