Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded spotbugs exclusions #1363

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Remove unneeded spotbugs exclusions #1363

merged 1 commit into from
Nov 22, 2022

Conversation

MarkEWaite
Copy link
Contributor

Remove unused spotbugs exclusions

Spotbugs has improved their detectors in the last two months. These are no longer raised as warnings.

@MarkEWaite MarkEWaite requested a review from a team as a code owner November 22, 2022 01:32
@MarkEWaite MarkEWaite enabled auto-merge (squash) November 22, 2022 01:35
@MarkEWaite
Copy link
Contributor Author

@jmMeessen or @gounthar could you approve this change? Consistent with the same change made in Jenkins core and in many plugins by Basil Crow.

Copy link
Contributor

@gounthar gounthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks Mark!

@MarkEWaite MarkEWaite merged commit 26be5c7 into jenkinsci:master Nov 22, 2022
@MarkEWaite MarkEWaite deleted the remove-unneeded-spotbugs-exclusions branch November 27, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants