Bump plugin from 4.51 to 4.53 #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [plugin](https://github.com/jenkinsci/plugin-pom) from 4.51 to 4.53. - [Release notes](https://github.com/jenkinsci/plugin-pom/releases) - [Changelog](https://github.com/jenkinsci/plugin-pom/blob/master/CHANGELOG.md) - [Commits](jenkinsci/plugin-pom@plugin-4.51...plugin-4.53) --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins:plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
gounthar
added
the
enhancement
|
One of your CI runs failed on this pull request, so Dependabot won't merge it. Dependabot will still automatically merge this pull request if you amend it and your tests pass. |
MarkEWaite
approved these changes
Dec 14, 2022
…fy 'maven' or 'gradle' as appropriate.
|
We have a compilation error in the security scan: |
Does not fix the test failure, but at least fixes compilation
|
Compilation error is also visible in the regular development. Thanks for catching it. Jetty 9 to Jetty 10 transition in Jenkins parent pom exposes an API change that was made in that transition. The |
|
Thanks a lot, let me have a look at the test failure. |
|
Using mvn -ntp clean verify -Denforcer.skip=trueA lot of the tests errors I get are about timeout
and about Signing service is not available 🤔
In the GItHub check, we see different errors/warning as this one:
I don't know if this has to do with our issue, but I read:
I have to dig, but I think we're using |
|
That's surprising. I see the same error locally as is failing in the CI jobs. The error I see is: If time allows tomorrow or later this week, I may perform an interactive test of the scenario that the automated test is trying to duplicate. I assume that Jetty 9 and Jetty 10 will behave the same in both cases. If that is what happens, that would provide more argument that the test failure is purely a test artifact, not a failure of production code. |
|
I guess that, one more time, the platform I use is not the correct one (Debian on top of (through?) WSL2). 🤔 |
|
I'm also using JDK17. 🤦 |
Test relies on a Jetty API that changed from Jetty 9 to Jetty 10. Test is not worth delaying the use of the most recent parent pom. Also improves the assertion of the remaining certificate test so that it is asserting a more precise failure condition. Confirmed the new assertion passes with Java 11 and with Java 17.
dependabot
bot
deleted the
dependabot/maven/org.jenkins-ci.plugins-plugin-4.53
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps plugin from 4.51 to 4.53.
Release notes
Sourced from plugin's releases.
Commits
bd659b1[maven-release-plugin] prepare release plugin-4.53ae96031Bump maven-hpi-plugin from 3.37 to 3.38 (#659)3f48663Bump jenkins-test-harness (#658)4747a17Bump access-modifier-checker from 1.29 to 1.30 (#657)1a6b694Bump jenkins-test-harness (#656)684e3d9[maven-release-plugin] prepare for next development iterationf4b1eea[maven-release-plugin] prepare release plugin-4.521abb634Bump maven-hpi-plugin from 3.36 to 3.37 (#655)cedb8a8Bump jenkins-test-harness from 1900.v9e128c991ef4 to 1903.vf505ecb_63589 (#654)adc397aBump maven-stapler-plugin from 1.20 to 1.21 (#653)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot will merge this PR once CI passes on it, as requested by @MarkEWaite.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)