Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GitLabCommitStatusStep NullPointerExcetion bug #1407

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Fix GitLabCommitStatusStep NullPointerExcetion bug #1407

merged 1 commit into from
Feb 9, 2023

Conversation

krisstern
Copy link
Member

Fixes #1405.

@krisstern krisstern requested a review from a team as a code owner February 9, 2023 09:33
@krisstern krisstern mentioned this pull request Feb 9, 2023
Closed
@krisstern krisstern self-assigned this Feb 9, 2023
@krisstern krisstern merged commit 3b1f4e2 into jenkinsci:master Feb 9, 2023
@krisstern krisstern deleted the fix/gitlabcommitstatusstep-onfailure-bug branch February 9, 2023 10:19
@impact-maker
Copy link

Hi @krisstern I was trying to understand the development workflow for gitlab plugins. In order to work on this null pointer exception issue, what commands did you use to build the code after making these code changes and once you made those changes, what sort of tests did you use to cross check whether the null pointer exception has been fixed for this plugin. Thank you, eagerly waiting for your reply.

@krisstern
Copy link
Member Author

Hi @impact-maker I think the issue has been partially fixed, but the work is not yet finished. You can see the details in #1030. Regarding work flow for testing, you may refer to https://github.com/jenkinsci/gitlab-plugin/blob/2b2c067893c119ca7c29c74069ce1789916a4c5e/src/docker/README.md. Let me know if there is anything else that you will need.

Cheers!

@krisstern
Copy link
Member Author

Hi @impact-maker As the patch is kind of urgent and I have not heard from you since you last volunteered to help, I have submitted a PR for it at #1410.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@krisstern krisstern

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitLabCommitStatusStepExecution raise NPE cause agent can't be deleted automatically
2 participants
@krisstern @impact-maker