Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve global auth instructions #1511

Merged

Conversation

MarkEWaite
Copy link
Contributor

Match current UI in global authorization instructions

  • Simppler phrasing
  • Jenkins user API tokens use "Add new Token" now
  • Replace outdated issues with more general text

@MarkEWaite MarkEWaite requested a review from a team as a code owner June 19, 2023 23:38
@MarkEWaite MarkEWaite added the documentation Improvements or additions to documentation label Jun 19, 2023
Copy link
Member

@krisstern krisstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krisstern krisstern merged commit b161032 into jenkinsci:master Jun 20, 2023
@krisstern
Copy link
Member

Thanks @MarkEWaite

@MarkEWaite MarkEWaite deleted the improve-global-auth-instructions branch June 20, 2023 14:53
krisstern added a commit that referenced this pull request Jun 21, 2023
…#1512)

* Bump maven-failsafe-plugin from 3.1.0 to 3.1.2 (#1502)

* Update Jenkins version to 2.387.3 in pom.xml (#1504)

* Bumps plugin pom from 4.66 to 4.67. (#1506)

https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.67 provides
more details of the changes, including:

* Fix hamcrest versioning - @timja
  https://redirect.github.com/jenkinsci/plugin-pom/issues/785

* Update HtmlUnit package for jacoco - @timja
  https://redirect.github.com/jenkinsci/plugin-pom/issues/778

* Use latest plugin BOM for 2.387.x (#1507)

The minimum Jenkins version is already set to 2.387.3 so we should also
update the plugin bill of materials to rely on 2.387.x as well.

* Improve global auth instructions (#1511)

* Simppler phrasing

* Jenkins user API tokens use "Add new Token" now

* Replace outdated issues with more geneeral text

* Remove outdated version support reference (#1510)

Better to not mention a specific version than to mention a specific
version that is many years outdated.

Co-authored-by: Bruno Verachten <[email protected]>

---------

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kris Stern <[email protected]>
Co-authored-by: Mark Waite <[email protected]>
Co-authored-by: Bruno Verachten <[email protected]>
Co-authored-by: Sync project branch action <[email protected]>
krisstern added a commit that referenced this pull request Jun 22, 2023
…#1513)

* Bump maven-failsafe-plugin from 3.1.0 to 3.1.2 (#1502)

* Update Jenkins version to 2.387.3 in pom.xml (#1504)

* Bumps plugin pom from 4.66 to 4.67. (#1506)

https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.67 provides
more details of the changes, including:

* Fix hamcrest versioning - @timja
  https://redirect.github.com/jenkinsci/plugin-pom/issues/785

* Update HtmlUnit package for jacoco - @timja
  https://redirect.github.com/jenkinsci/plugin-pom/issues/778

* Use latest plugin BOM for 2.387.x (#1507)

The minimum Jenkins version is already set to 2.387.3 so we should also
update the plugin bill of materials to rely on 2.387.x as well.

* Improve global auth instructions (#1511)

* Simppler phrasing

* Jenkins user API tokens use "Add new Token" now

* Replace outdated issues with more geneeral text

* Remove outdated version support reference (#1510)

Better to not mention a specific version than to mention a specific
version that is many years outdated.

Co-authored-by: Bruno Verachten <[email protected]>

---------

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kris Stern <[email protected]>
Co-authored-by: Mark Waite <[email protected]>
Co-authored-by: Bruno Verachten <[email protected]>
Co-authored-by: Sync project branch action <[email protected]>
krisstern added a commit that referenced this pull request Jun 23, 2023
…#1514)

* Bump maven-failsafe-plugin from 3.1.0 to 3.1.2 (#1502)

* Update Jenkins version to 2.387.3 in pom.xml (#1504)

* Bumps plugin pom from 4.66 to 4.67. (#1506)

https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.67 provides
more details of the changes, including:

* Fix hamcrest versioning - @timja
  https://redirect.github.com/jenkinsci/plugin-pom/issues/785

* Update HtmlUnit package for jacoco - @timja
  https://redirect.github.com/jenkinsci/plugin-pom/issues/778

* Use latest plugin BOM for 2.387.x (#1507)

The minimum Jenkins version is already set to 2.387.3 so we should also
update the plugin bill of materials to rely on 2.387.x as well.

* Improve global auth instructions (#1511)

* Simppler phrasing

* Jenkins user API tokens use "Add new Token" now

* Replace outdated issues with more geneeral text

* Remove outdated version support reference (#1510)

Better to not mention a specific version than to mention a specific
version that is many years outdated.

Co-authored-by: Bruno Verachten <[email protected]>

---------

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kris Stern <[email protected]>
Co-authored-by: Mark Waite <[email protected]>
Co-authored-by: Bruno Verachten <[email protected]>
Co-authored-by: Sync project branch action <[email protected]>
krisstern added a commit that referenced this pull request Jun 24, 2023
…#1515)

* Bump maven-failsafe-plugin from 3.1.0 to 3.1.2 (#1502)

* Update Jenkins version to 2.387.3 in pom.xml (#1504)

* Bumps plugin pom from 4.66 to 4.67. (#1506)

https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.67 provides
more details of the changes, including:

* Fix hamcrest versioning - @timja
  https://redirect.github.com/jenkinsci/plugin-pom/issues/785

* Update HtmlUnit package for jacoco - @timja
  https://redirect.github.com/jenkinsci/plugin-pom/issues/778

* Use latest plugin BOM for 2.387.x (#1507)

The minimum Jenkins version is already set to 2.387.3 so we should also
update the plugin bill of materials to rely on 2.387.x as well.

* Improve global auth instructions (#1511)

* Simppler phrasing

* Jenkins user API tokens use "Add new Token" now

* Replace outdated issues with more geneeral text

* Remove outdated version support reference (#1510)

Better to not mention a specific version than to mention a specific
version that is many years outdated.

Co-authored-by: Bruno Verachten <[email protected]>

---------

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kris Stern <[email protected]>
Co-authored-by: Mark Waite <[email protected]>
Co-authored-by: Bruno Verachten <[email protected]>
Co-authored-by: Sync project branch action <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants