-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all trigger fields to the documentation #1602
Conversation
@AniketNS thanks for the pull request. In future pull requests, please submit them from a branch that is not the primary branch of the repository. In the case of this repository, the primary branch is named "master". You submitted this pull request from the master branch of your local fork. That meant I had to take some extra steps in order to push the white space correction in 5c4aad3 The pull request checklist does not include that item, but should, since it is a preferred practice in most open source projects and a preferred practice in the Jenkins project. I've proposed a pull request to adjust the pull request template in this repository so that it matches with other Jenkins plugins.. That pull request is: No need to make any change to this pull request. Using the master branch as the basis for this pull request is only a minor inconvenience. I only mention it in this review comment for future pull requests. Don't disrupt the review process of this pull request by attempting to change the base branch used for the changes. |
Sure @MarkEWaite, actually I did create a different branch named |
The GitHub pull request documentation provides a very good description of the process. If you prefer it in a video format specifically for Jenkins, refer to the "Improve a plugin" tutorial. |
Ok, Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I have added the missing trigger fields to the
gitLabConnection
pipeline trigger andgitLabBuilds
for issue #1477