Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all trigger fields to the documentation #1602

Merged
merged 5 commits into from
Jan 1, 2024
Merged

Add all trigger fields to the documentation #1602

merged 5 commits into from
Jan 1, 2024

Conversation

AniketNS
Copy link
Contributor

I have added the missing trigger fields to the gitLabConnection pipeline trigger and gitLabBuilds for issue #1477

@AniketNS AniketNS requested a review from a team as a code owner December 30, 2023 11:02
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 30, 2023
@MarkEWaite
Copy link
Contributor

@AniketNS thanks for the pull request. In future pull requests, please submit them from a branch that is not the primary branch of the repository. In the case of this repository, the primary branch is named "master". You submitted this pull request from the master branch of your local fork. That meant I had to take some extra steps in order to push the white space correction in 5c4aad3

The pull request checklist does not include that item, but should, since it is a preferred practice in most open source projects and a preferred practice in the Jenkins project.

I've proposed a pull request to adjust the pull request template in this repository so that it matches with other Jenkins plugins.. That pull request is:

No need to make any change to this pull request. Using the master branch as the basis for this pull request is only a minor inconvenience. I only mention it in this review comment for future pull requests. Don't disrupt the review process of this pull request by attempting to change the base branch used for the changes.

@AniketNS
Copy link
Contributor Author

Sure @MarkEWaite, actually I did create a different branch named aniket but when I pushed code from that branch, I didn't see the compare and pull request on GitHub. I don't know why this happened. That's why once again I pushed code from the master branch. You can see the commits.

@MarkEWaite
Copy link
Contributor

The GitHub pull request documentation provides a very good description of the process.

If you prefer it in a video format specifically for Jenkins, refer to the "Improve a plugin" tutorial.

@AniketNS
Copy link
Contributor Author

The GitHub pull request documentation provides a very good description of the process.

If you prefer it in a video format specifically for Jenkins, refer to the "Improve a plugin" tutorial.

Ok, Thanks

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite changed the title Added all trigger fields to the documentation Add all trigger fields to the documentation Jan 1, 2024
@MarkEWaite MarkEWaite merged commit 149614f into jenkinsci:master Jan 1, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants