Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring and simplifying the codebase #1621

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

shivajee98
Copy link
Contributor

@shivajee98 shivajee98 commented Jan 16, 2024

-Strengthen NullPointerException handling in
src/main/java/com/dabsquared/gitlabjenkins/GitLabPushTrigger.java,
src/main/java/com/dabsquared/gitlabjenkins/gitlab/api/GitLabClientBuilder.java,
src/main/java/com/dabsquared/gitlabjenkins/publisher/GitLabMessagePublisher.java,
src/main/java/com/dabsquared/gitlabjenkins/trigger/handler/PendingBuildsHandler.java,
src/main/java/com/dabsquared/gitlabjenkins/webhook/build/BuildWebHookAction.java,
src/main/java/com/dabsquared/gitlabjenkins/webhook/status/BuildPageRedirectAction.java,
src/main/java/com/dabsquared/gitlabjenkins/workflow/GitLabCommitStatusStep.java

@shivajee98 shivajee98 requested a review from a team as a code owner January 16, 2024 16:20
@krisstern
Copy link
Member

Thanks for making the requested changes @shivajee98!

Copy link
Member

@krisstern krisstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krisstern krisstern merged commit 56e4509 into jenkinsci:master Jan 16, 2024
17 checks passed
@krisstern krisstern added the bug For changelog: Minor bug. Will be listed after features label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants