Possible to disable service links #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
timja
reviewed
Sep 9, 2024
jonesbusy
force-pushed
the
feature/enableServiceLinks
branch
from
46ad02c
to
dd32c83
Compare
jonesbusy
force-pushed
the
feature/enableServiceLinks
branch
from
dd32c83
to
3616a4d
Compare
timja
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow to disable services links (my original issue jenkinsci/docker#1905) that might cause startup performance issue when the shell contains a huge amount of environment variables due to a large number of service
If you modified files in the
./charts/jenkins/directory, please also include the following:Submitter checklist
Special notes for your reviewer