Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins Helm chart is now also published to GitHub packages registry (oci://ghcr.io/jenkinsci/helm-charts/jenkins) #1196

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

jonesbusy
Copy link
Contributor

What does this PR do?

Publish also the chart to the GHCR registry

  • Fixes

#1180

Submitter checklist

Special notes for your reviewer

This was inspired from https://github.com/fluxcd-community/helm-charts/pull/94/files

Chart is published on both location (the traditional GH page and the GH package)

I've tested the workflow change on my fork

action
https://github.com/jonesbusy/helm-charts/actions/runs/10828217018

@jonesbusy jonesbusy requested a review from a team as a code owner September 12, 2024 09:43
@jonesbusy jonesbusy changed the title Jenkins Helm chart is now also published to GitHub packages registry (oci://ghcr.io/jenkinci/helm-charts/jenkins) Jenkins Helm chart is now also published to GitHub packages registry (oci://ghcr.io/jenkinsci/helm-charts/jenkins) Sep 12, 2024
@jonesbusy
Copy link
Contributor Author

Fixed the .github/workflows/release.yaml:29:15: the runner of "docker/login-action@v1 is too old...." by using docker/login-action@v3

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets give it a whirl, can you make some sort of change to the chart as well please to trigger a release?

@jonesbusy jonesbusy requested a review from a team as a code owner September 12, 2024 13:46
@jonesbusy
Copy link
Contributor Author

@timja Well I've just bumped the version which should be enough to trigger a release on merge

- name: Install Helm
uses: azure/setup-helm@v4
with:
version: v3.12.0
version: v3.16.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This deserve perhaps renovate (on an other PR) to keep the binary up to date

@timja timja merged commit e5123d4 into jenkinsci:main Sep 12, 2024
6 checks passed
@jonesbusy jonesbusy deleted the feature/publish-ghcr branch September 12, 2024 16:07
@jonesbusy
Copy link
Contributor Author

Looks good:
https://github.com/jenkinsci/helm-charts/pkgs/container/helm-charts%2Fjenkins

Perhaps the package view can be enabled for the repo (Like the deployments)

@timja
Copy link
Member

timja commented Sep 12, 2024

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants