replace invalid "+" with valid character

[ritzk]

What does this PR do?

replace '+' with '_' in chart version.

flux will version chart with + when using revision reconciliation strategy. This break deployment.

• Fixes #

deployment via flux

 Helm upgrade failed for release jenkins/jenkins with chart [email protected]+087b605ce3dd.11: 
   cannot patch "jenkins-jenkins-config-credentials" with kind ConfigMap: 
     ConfigMap "jenkins-jenkins-config-credentials" is invalid: 
       metadata.labels: Invalid value: "jenkins-5.6.1+087b605ce3dd.11":

If you modified files in the ./charts/jenkins/ directory, please also include the following:

Submitter checklist

Beta Give feedback

1. I bumped the "version" key in ./charts/jenkins/Chart.yaml.
2. I added a new changelog entry to ./charts/jenkins/CHANGELOG.md.
3. I followed the technical requirements.
4. I ran .github/helm-docs.sh from the project root.

Special notes for your reviewer

[timja]

Why does it have that version we don't have that? Can you point to some documentation from helm or flux please.

[ritzk]

Why does it have that version we don't have that? Can you point to some documentation from helm or flux please.

jenkins chart is checked into local git repo (mirrored from upstream).

flux/source-controller will append git hash to chart version when using gitrepository with revision reconciliation
https://github.com/fluxcd/source-controller/blob/main/CHANGELOG.md#0191