add support for customizing kubernetes jnlpregistry #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrwielgolaski-tomtom
force-pushed
the
feature/support_private_registry
branch
from
39711e6
to
6e7cda3
Compare
|
Hey, Thanks for the PR! Would you mind documenting the key in https://github.com/jenkinsci/helm-charts/blob/main/charts/jenkins/VALUES_SUMMARY.md too? |
piotrwielgolaski-tomtom
force-pushed
the
feature/support_private_registry
branch
from
6e7cda3
to
5793819
Compare
Sure, done |
NotMyFault
approved these changes
Jul 11, 2023
|
Could you rebase the PR, please? |
piotrwielgolaski-tomtom
force-pushed
the
feature/support_private_registry
branch
from
5793819
to
6ce6f3a
Compare
|
I rebased it as requested |
timja
reviewed
Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
extend configuration options with extra parameter jnlpregistry
If you modified files in the
./charts/jenkins/directory, please also include the following:Submitter checklist
Special notes for your reviewer