Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow cloning home-pvc from custom dataSource #899

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

joshuasimon-taulia
Copy link
Contributor

What does this PR do?

Add the ability to clone the home PVC from an existing volume, GCP snapshot, etc as described in CSI Volume Cloning. Not only is this useful for CI/testing against the jenkins chart, this can also be used to restore from a backup or to facilitate a major jenkins version upgrade.

If you modified files in the ./charts/jenkins/ directory, please also include the following:

Submitter checklist

Special notes for your reviewer

i added tests

@joshuasimon-taulia joshuasimon-taulia requested a review from a team as a code owner July 27, 2023 23:15
@joshuasimon-taulia
Copy link
Contributor Author

joshuasimon-taulia commented Jul 27, 2023

https://github.com/jenkinsci/helm-charts/actions/runs/5686349589/job/15412972064?pr=899

Retrieving https://api.github.com/repos/quintush/helm-unittest/releases/tags/v0.2.11
No download_url found only searching for linux
Downloading  to location /tmp/_dist/
curl: Remote file name has no length!
curl: (23) Failed writing received data to disk/application
Failed to install helm-unittest
Error: plugin install hook for "unittest" exited with error
For support, go to https://github.com/kubernetes/helm
Error: Process completed with exit code 1.

this probably needs to be updated to the upstream https://github.com/helm-unittest/helm-unittest/releases/tag/v0.2.11. @timja @NotMyFault mind re-running/having alook?

@joshuasimon-taulia joshuasimon-taulia changed the title Pvc datasource feat: allow cloning home-pvc from custom dataSource Jul 27, 2023
@timja timja merged commit 1f32bcc into jenkinsci:main Jul 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants