Add variables to support cert-manager generated certificates #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
reviewed
Aug 21, 2023
There was a problem hiding this comment.
can you add a unit test please?
https://github.com/jenkinsci/helm-charts/blob/main/CONTRIBUTING.md#unit-tests
|
@timja added 2 unit test, let me know if there any thing else needed. |
|
@benzch Thanks a lot, could you rebase your PR, please? Currently, it conflicts with the default branch. |
|
@NotMyFault rebased main, no more conflicts. |
timja
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When Issuing the SSL certificate with Cert-manager it creates Kubernetes secret of type kubernetes.io/tls without the ability to define the secret keys (jks file is stored in keystore.jks). Since the helm chart expects the keystore file in the hardcoded key name it is not possible to use cert-manager issued certificate.
This PR adds the ability to use a secret that already has SSL keystore with a variable name key in the secret and not just the default "jenkins-jks-file".
If you modified files in the
./charts/jenkins/directory, please also include the following:Submitter checklist
Special notes for your reviewer
This is mostly inspired by #404