Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for ephemeral storage requests and limits to casc t… #936

Merged
merged 7 commits into from
Oct 19, 2023
Merged

feat: add support for ephemeral storage requests and limits to casc t… #936

merged 7 commits into from
Oct 19, 2023

Conversation

knechtionscoding
Copy link
Contributor

…emplates

What does this PR do?

If you modified files in the ./charts/jenkins/ directory, please also include the following:

Submitter checklist

Special notes for your reviewer

@knechtionscoding knechtionscoding requested a review from a team as a code owner October 19, 2023 01:25
@knechtionscoding
Copy link
Contributor Author

hknecht:helm-charts-jenkins/ (main✗) $ helm unittest --helm3 --strict -f 'unittests/*.yaml' charts/jenkins                                                                                              

### Chart [ jenkins ] charts/jenkins

2023/10/18 21:21:03 warning: destination for jenkins.controller.initScripts is a table. Ignoring non-table value ([])
 PASS  ConfigMap        charts/jenkins/unittests/config-init-scripts-test.yaml
 PASS  ConfigMap        charts/jenkins/unittests/config-test.yaml
 PASS  PersistentVolumeClaim    charts/jenkins/unittests/home-pvc-test.yaml
2023/10/18 21:21:03 warning: destination for jenkins.controller.projectNamingStrategy is a table. Ignoring non-table value (standard)
2023/10/18 21:21:03 warning: cannot overwrite table with non table for jenkins.controller.JCasC.security.apiToken (map[creationOfLegacyTokenEnabled:false tokenGenerationOnCreationEnabled:false usageStatisticsEnabled:true])
 PASS  Configuration as Code    charts/jenkins/unittests/jcasc-config-test.yaml
 PASS  Jenkins Agent Service    charts/jenkins/unittests/jenkins-agent-svc-test.yaml
 PASS  Jenkins Backup Cronjob   charts/jenkins/unittests/jenkins-backup-cronjob-test.yaml
 PASS  Controller Prometheus PrometheusRule     charts/jenkins/unittests/jenkins-controller-alerting-rules-test.yaml
 PASS  Controller Primary Ingress       charts/jenkins/unittests/jenkins-controller-ingress-1.19-test.yaml
 PASS  Controller Ingress - DRY Support charts/jenkins/unittests/jenkins-controller-ingress-DRY-test.yaml
 PASS  Controller Primary Ingress       charts/jenkins/unittests/jenkins-controller-ingress-test.yaml
 PASS  Network Policy   charts/jenkins/unittests/jenkins-controller-networkpolicy-test.yaml
 PASS  Controller Pod Disruption Budget charts/jenkins/unittests/jenkins-controller-pdb-1.21-test.yaml
 PASS  Controller Pod Disruption Budget charts/jenkins/unittests/jenkins-controller-pdb-test.yaml
 PASS  Controller Secondary Ingress     charts/jenkins/unittests/jenkins-controller-secondary-ingress-1.19-test.yaml
 PASS  Controller Secondary Ingress     charts/jenkins/unittests/jenkins-controller-secondary-ingress-test.yaml
 PASS  Controller Prometheus ServiceMonitor     charts/jenkins/unittests/jenkins-controller-servicemonitor_test.yaml
 PASS  Jenkins Controller       charts/jenkins/unittests/jenkins-controller-statefulset-test.yaml
 PASS  Jenkins Controller       charts/jenkins/unittests/jenkins-controller-svc-test.yaml
 PASS  Role Based Access Control        charts/jenkins/unittests/rbac-test.yaml
 PASS  Controller Admin Additional Secrets      charts/jenkins/unittests/secret-additional-test.yaml
 PASS  Controller Secret Claims charts/jenkins/unittests/secret-claims-test.yaml
 PASS  Controller Additional Existing Secrets   charts/jenkins/unittests/secret-existing-test.yaml
 PASS  Controller Admin Credentials     charts/jenkins/unittests/secret-test.yaml
 PASS  Controller Service Account       charts/jenkins/unittests/service-account-agent-test.yaml
 PASS  Controller Service Account       charts/jenkins/unittests/service-account-test.yaml

Charts:      1 passed, 1 total
Test Suites: 25 passed, 25 total
Tests:       154 passed, 154 total
Snapshot:    1 passed, 1 total
Time:        1.00814175s

It passes linting locally. I'm not sure why the linting for 1.26.4 is failing. It appears to be failing on the download, so I think it's just a flake?

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these should be commented out by default, so that people can see that they can set it but it doesn't set a value by default

charts/jenkins/values.yaml Outdated Show resolved Hide resolved
charts/jenkins/values.yaml Outdated Show resolved Hide resolved
charts/jenkins/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timja timja merged commit d386d1a into jenkinsci:main Oct 19, 2023
5 checks passed
@knechtionscoding knechtionscoding deleted the feat/add-ephemeral-storage-resources branch October 19, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support EphemeralStorage requests and limits in CASC templates
2 participants