Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid trailing underscore #31

Merged
merged 2 commits into from
Jul 19, 2022
Merged

avoid trailing underscore #31

merged 2 commits into from
Jul 19, 2022

Conversation

jetersen
Copy link
Member

@jetersen jetersen commented Jul 19, 2022 •
edited
Loading

as it is not considered a canonical release
Also trailing underscore makes linking to GitHub releases harder as GitHub seems to chop the last _ from anchor's href

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jetersen
avoid trailing underscore
cddbe3b 
as it is not considered a canonical release
@jetersen jetersen mentioned this pull request Jul 19, 2022
Closed
@timja timja requested a review from jglick July 19, 2022 21:14
@jglick jglick added the enhancement New feature or request label Jul 19, 2022
@jglick jglick merged commit eb390da into jenkinsci:master Jul 19, 2022
@jetersen jetersen deleted the fix/trailingSanitize branch July 19, 2022 21:23
@jetersen
Copy link
Member Author

Well that was easy to land 😆

@jglick
Copy link
Member

jglick commented Jul 19, 2022

https://github.com/jenkinsci/incrementals-tools/releases/tag/parent-1.4

@timja
Copy link
Member

timja commented Jul 19, 2022

interesting tag name :shipit:

@jglick
Copy link
Member

jglick commented Jul 19, 2022

Yeah, well, MRP.

@jetersen
Copy link
Member Author

@jglick fixable via config/property: https://github.com/jenkinsci/configuration-as-code-plugin/blob/bf985b894e408c24b07902a43a1d228758e5ce57/pom.xml#L25

@jglick
Copy link
Member

jglick commented Jul 19, 2022

I know, just do not much care. If you do, fix it w/

incrementals-tools/.github/release-drafter.yml

Line 2 in f909d7b

tag-template: parent-$NEXT_MINOR_VERSION

@jglick jglick mentioned this pull request Aug 25, 2022
Merged
@basil basil mentioned this pull request Jan 22, 2023
Closed
@basil
Copy link
Member

basil commented Jan 24, 2023

Caused #34.

@jglick jglick mentioned this pull request Feb 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basil basil basil approved these changes

@jglick jglick jglick approved these changes

@timja timja timja approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jetersen @jglick @timja @basil