-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix JacksonJsonProvider
#111
Conversation
@jenkinsci/jackson2-api-plugin-developers Could this please be merged and released? This problem is affecting multiple users of the GitLab plugin. |
Users have tested this fix successfully:
|
I tested:
and confirm our Jenkins instance was unusable with latest release, and fixed by installing the snapshot with fix. |
The Jackson plugin is used by a huge amount of plugins. To put it another way should jaxrs be a plugin that is optional here? On my phone so sorry if this is short and I can not look into this myself right now |
I don't know, James. |
a quick search for both the old and new jax-rs |
@jtnord when can we expect a new release? |
Seems that this change somehow causes other side-effects - jenkinsci/jira-plugin#398 , @basil do you have an idea what can be the issue here? |
Similar report in jenkinsci/urltrigger-plugin#45. I'll look into it. Do you have steps to reproduce the problem? |
I think I see what is going on. I'm going to create a new JAX-RS 2 API plugin bundling Jersey 2, get that released, then remove JAX-RS from this plugin and add an optional dependency on the (new) JAX-RS 2 API plugin. |
Hosting request submitted: jenkins-infra/repository-permissions-updater#2292 |
Fixes jenkinsci/gitlab-plugin#1206 by bundling the JAX-RS API JAR in the Jackson 2 API plugin. The new
RealJenkinsRule
-based test fails before this PR and passes with it. I have also written a functional test in jenkinsci/gitlab-plugin#1207 which fails before this PR and passes with it.