Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-65757] only use pluginFirst classloader when you have no other option (and never for guice!) #151

Merged
merged 7 commits into from
Jun 17, 2021
Merged

[JENKINS-65757] only use pluginFirst classloader when you have no other option (and never for guice!) #151

merged 7 commits into from
Jun 17, 2021

Commits on Jun 7, 2021

  1. Add a full e2e test using realistic class loading

    @jtnord
    jtnord committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    f705075 View commit details
    Browse the repository at this point in the history

  2. remove the need for maven / guice 

    FileFilter just joined the passed in excludes as a comma separated list
and added defaults if the list was empty or null, But the code already handles this so just call the Plex util directly
    @jtnord
    jtnord committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    44a9081 View commit details
    Browse the repository at this point in the history

  3. httpcomponents was declared as a dependency but unused and bundled

    @jtnord
    jtnord committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    03819b3 View commit details
    Browse the repository at this point in the history

  4. xml-apis was declared bundled and unused

    @jtnord
    jtnord committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    92279d9 View commit details
    Browse the repository at this point in the history

  5. final clean up of unrequired stuff

    @jtnord
    jtnord committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    91837c8 View commit details
    Browse the repository at this point in the history

  6. skip the instruction coverage as it is compiler specific 

    JDK11 and JDK8 compilers generate different bytecode and so asserting
the bytecode instruction coverage would need to be different on
potentially different compilers (e.g eclipse vs jdk 8 vs jdk11 vs ...)
    @jtnord
    jtnord committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    d8d300a View commit details
    Browse the repository at this point in the history

  7. remove shade configuration - it did nothing. 

    the shade plugin was bound to a phase that did not exist in the hpi
packaging type.

even if it did it would be completely unclear what it did as the shade
plugin does not play nicely with hpis.
    @jtnord
    jtnord committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    40f5613 View commit details
    Browse the repository at this point in the history