Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for sunset icon removal from core #172

Merged

Conversation

NotMyFault
Copy link
Member

@NotMyFault NotMyFault commented Dec 12, 2021

This is a preparation for jenkinsci/jenkins#5778 which removes sunset icons.

Otherwise we're lacking an icon here:

Which has been mitigated:

cc @centic9

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Please describe what you did
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@centic9 centic9 merged commit c648bd2 into jenkinsci:master Dec 12, 2021
@NotMyFault NotMyFault deleted the chore/master/prep-for-core-5778 branch December 12, 2021 21:41
@NotMyFault
Copy link
Member Author

NotMyFault commented Dec 14, 2021

@centic9 thanks for the quick merge, can we may get a release? The mentioned core PR is blocked until plugin PRs are merged and included in some release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants