Upgrade Mockito; remove PowerMock #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Used my admin powers to replay the build with the |
|
Thanks! |
|
@centic9 Could this please be released? A release would allow the Jenkins core developers to do plugin compatibility testing (PCT) of this plugin on Java 17 in jenkinsci/bom#1828. |
|
Sorry, but I need to wait for another release here before I can release these changes. Not sure when exactly it is done. |
|
@basil, fyi release 3.3.3 is now available with this change! |
|
Thank you! I have filed jenkinsci/bom#1889 to add this plugin to our Plugin Compatibility Test (PCT) matrix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PowerMock has been removed from the plugin parent POM and does not work with Java 17, and it does not work with recent versions of Mockito. This PR replaces usage of PowerMock with the latest version of mockito-inline, which supports Java 17. Reviewers are encouraged to review this PR with the Hide Whitespace feature enabled. CC @centic9