Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow RealJenkinsRule instances to specify a name & color #514

Merged
merged 7 commits into from
Nov 19, 2022

Conversation

jglick
Copy link
Member

@jglick jglick commented Nov 11, 2022

At CloudBees we often multiple RealJenkinsRule rules simultaneously to model the interaction among multiple controllers. It is much easier to follow log output when log lines are prefixed with a controller identifier, and (when running interactively) are colored.

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fancy!

src/main/java/org/jvnet/hudson/test/RealJenkinsRule.java Outdated Show resolved Hide resolved
@Vlatombe
Copy link
Member

These name and color logic could be reused for InboundAgentRule.

@jglick
Copy link
Member Author

jglick commented Nov 18, 2022

Yes, I think that would work.

@jglick jglick mentioned this pull request Nov 18, 2022
@jglick
Copy link
Member Author

jglick commented Nov 18, 2022

Core PR demonstrating this coming as soon as I get an incremental build…

@jglick
Copy link
Member Author

jglick commented Nov 18, 2022

jenkinsci/jenkins#7411

@basil basil merged commit 471a047 into jenkinsci:master Nov 19, 2022
@jglick jglick deleted the RealJenkinsRule-name-color branch November 21, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants