[JENKINS-57515] update JNA library from 4.5.2 to 5.3.1 #4060
Conversation
This solves problems with loading native libraries of jna on AIX platform when using openJDK or other JDKs that assume .so is the extension for shared libraries
There was a problem hiding this comment.
We reviewed the incompatible changes together with @fcojfernandez , and it looks like there is no incompatible changes impacting the plugins within jenkinsci. We did not reviewed SVNkit tho: https://github.com/jenkinsci/svnkit
@mawinter69 could you please review the SVNKit library against https://github.com/java-native-access/jna/blob/master/CHANGES.md#breaking-changes? It may impact the SVN plugin
| @@ -1442,7 +1441,7 @@ private SolarisProcess(int pid) throws IOException { | |||
| * Read the remainder of psinfo_t differently depending on whether the | |||
| * Java process is 32-bit or 64-bit. | |||
| */ | |||
| if (Pointer.SIZE == 8) { | |||
There was a problem hiding this comment.
Is it a binary incompatible change in JNA?
UPD: No https://github.com/java-native-access/jna/blob/master/src/com/sun/jna/Pointer.java has no reference to SIZE anymore.
| @@ -534,7 +534,7 @@ THE SOFTWARE. | |||
| <dependency> | |||
| <groupId>net.java.dev.jna</groupId> | |||
| <artifactId>jna</artifactId> | |||
| <version>4.5.2</version> | |||
| <version>5.3.1</version> | |||
There was a problem hiding this comment.
Breaking changes are listed here: https://github.com/java-native-access/jna/blob/master/CHANGES.md#breaking-changes
|
The svnkit used by subversion plugin is version 1.9.3. The svnkit in https://github.com/jenkinsci/svnkit seems to be no longer used by subversion plugin. |
|
I will check whether we can archive the repo to avoid confusion
…On Tue, Jun 11, 2019, 18:12 mawinter69 ***@***.***> wrote:
The svnkit used by subversion plugin is version 1.9.3. The svnkit in
https://github.com/jenkinsci/svnkit seems to be no longer used by
subversion plugin.
I compiled the current svnkit by getting sources from
https://git.tmatesoft.com/repos/svnkit.git and using the 5.3.1 vesrion of
jna which worked fine.
So my assumption is that svnkit is compatible with new JNA.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4060?email_source=notifications&email_token=AAW4RIFXM25EPTBGD4DA4WLPZ7FFJA5CNFSM4HVB4C5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXNVI4A#issuecomment-500913264>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAW4RIC4YCWPMGVAXEOJHNDPZ7FFJANCNFSM4HVB4C5A>
.
|
oleg-nenashev
added
the
ready-for-merge
|
Will merge into the next weekly if no negative feedback. |
|
Looks like it caused regressions: https://issues.jenkins-ci.org/browse/JENKINS-58207 |
* [JENKINS-57515] update jna library to 5.3.1 This solves problems with loading native libraries of jna on AIX platform when using openJDK or other JDKs that assume .so is the extension for shared libraries * Pointer.SIZE -> Native.POINTER_SIZE * remove unnecessary import * adjust to changed api (cherry picked from commit ffa9abf)
This reverts commit a604ddc.
|
I was waiting for this revert (078c442) which I think will fix JENKINS-58211 as well. |
This solves problems with loading native librarie of JNA on AIX
platform when using openJDK or other JDKs that assume .so is the
extension for shared libraries (java-native-access/jna#1066)
See JENKINS-57515.
Proposed changelog entries
Submitter checklist
* Use the
Internal:prefix if the change has no user-visible impact (API, test frameworks, etc.)Desired reviewers