Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let ConfidentialKey & Secret do something from unit tests #4603

Merged
merged 9 commits into from
Mar 28, 2020
Merged

Let ConfidentialKey & Secret do something from unit tests #4603

merged 9 commits into from
Mar 28, 2020

Commits on Mar 26, 2020

  1. Delete ConfidentialStoreRule

    @jglick
    jglick committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    d845ac9 View commit details
    Browse the repository at this point in the history

  2. Also delete MockSecretRule so Secret.fromString works

    @jglick
    jglick committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    d2f8515 View commit details
    Browse the repository at this point in the history

  3. Secret.SECRET still referenced by SecretHelper in jenkins-test-harnes… 

    …s, used by RekeySecretAdminMonitorTest, also copied in publish-over-*-plugin
    @jglick
    jglick committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    8411816 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2020

  1. Merge branch 'master' of github.com:jenkinsci/jenkins into Confidenti… 

    …alStoreRule
    @jglick
    jglick committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    4ca1226 View commit details
    Browse the repository at this point in the history

  2. RSAConfidentialKey ought to use the same SecureRandom as the Confiden… 

    …tialStore; this also lets the mock use a fixed seed
    @jglick
    jglick committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    8672e47 View commit details
    Browse the repository at this point in the history

  3. For now ConfidentialStore.secureRandom can be abstract

    @jglick
    jglick committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    50034fb View commit details
    Browse the repository at this point in the history

  4. Some core unit tests can be rather verbose; set maven.test.redirectTe… 

    …stOutputToFile
    @jglick
    jglick committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    4cacf1c View commit details
    Browse the repository at this point in the history

  5. Looks like we need a ConfidentialStoreRule after all

    @jglick
    jglick committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    244a9c7 View commit details
    Browse the repository at this point in the history

  6. Restored another couple of usages

    @jglick
    jglick committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    dfc5bb9 View commit details
    Browse the repository at this point in the history