Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-70169] Add comments explaining the absence of breadcrumb items in resources/hudson/PluginManager #7489

Merged
merged 4 commits into from
Jan 14, 2023
Merged

[JENKINS-70169] Add comments explaining the absence of breadcrumb items in resources/hudson/PluginManager #7489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6f18e1a
[JENKINS-70169] Add missing breadcrumb items in resources/hudson/Plug…
lemeurherveCB Dec 7, 2022
812fc96
Merge branch 'master' into JENKINS-70169-breadcrumb-resources-hudson-…
lemeurherve Dec 7, 2022
4262be9
better no breadcrumb comment
lemeurherve Dec 8, 2022
7e13063
Replace breadcrumbs by a comment
lemeurherveCB Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/src/main/resources/hudson/PluginManager/advanced.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ THE SOFTWARE.
<j:set var="readOnlyMode" value="${!app.hasPermission(app.ADMINISTER)}"/>

<st:include page="sidepanel.jelly"/>
<!-- no need for additional breadcrumb here as the side panel offers enough functionality to browse between different pages -->

<l:main-panel>
<l:app-bar title="${%Advanced settings}"/>
Expand Down
1 change: 1 addition & 0 deletions core/src/main/resources/hudson/PluginManager/available.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ THE SOFTWARE.
<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:l="/lib/layout" xmlns:f="/lib/form">
<l:layout title="${%Available plugins} - ${%Plugin Manager}" permission="${app.SYSTEM_READ}">
<st:include page="sidepanel.jelly"/>
<!-- no need for additional breadcrumb here as the side panel offers enough functionality to browse between different pages -->

<l:main-panel>
<l:app-bar title="${%Plugins}" />
Expand Down
1 change: 1 addition & 0 deletions core/src/main/resources/hudson/PluginManager/installed.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ THE SOFTWARE.
<j:set var="readOnlyMode" value="${!app.hasPermission(app.ADMINISTER)}"/>

<st:include page="sidepanel.jelly"/>
<!-- no need for additional breadcrumb here as the side panel offers enough functionality to browse between different pages -->

<l:main-panel>
<l:app-bar title="${%Plugins}" />
Expand Down
1 change: 1 addition & 0 deletions core/src/main/resources/hudson/PluginManager/table.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ THE SOFTWARE.
</st:documentation>
<l:layout title="${%Updates} - ${%Plugin Manager}" permission="${app.SYSTEM_READ}">
<st:include page="sidepanel.jelly"/>
<!-- no need for additional breadcrumb here as we're on an "index" page already including breadcrumb -->

<l:main-panel>
<l:app-bar title="${%Plugins}" />
Expand Down